Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: TypeError when using offset box in expand mode with tightlayout #10538

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@tacaswell
Copy link
Member

commented Feb 19, 2018

Perfect minimal example from @ewels
suggested fix from @afvincent

Fixes #10476

PR Summary

PR Checklist

  • as Pytest style unit tests
  • Code is PEP 8 compliant

@tacaswell tacaswell added this to the v2.2.0 milestone Feb 19, 2018

FIX: TypeError when using offset box in expand mode with tightlayout
Perfect minimal example from @ewels
suggested fix from @afvincent

closes #10476
@dopplershift
Copy link
Contributor

left a comment

A bit of a hack is better than broken code since a "proper" fix seems to be elusive.

@tacaswell tacaswell force-pushed the tacaswell:fix_offsetbox branch from 759df51 to b177c85 Feb 19, 2018

@dstansby dstansby merged commit e574613 into matplotlib:master Feb 20, 2018

8 checks passed

ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project/library 67% (target 50%)
Details
codecov/project/tests No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

meeseeksdev bot pushed a commit that referenced this pull request Feb 20, 2018

@tacaswell tacaswell deleted the tacaswell:fix_offsetbox branch Feb 20, 2018

tacaswell added a commit that referenced this pull request Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.