Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stix_fonts_demo.py fails with bad refcount #1054

Merged
merged 1 commit into from Aug 3, 2012

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Aug 3, 2012

with the Agg backend, trying to build docs, I get:

python stix_fonts_demo.py

python2.7: CXX/Python2/cxx_extensions.cxx:1320: virtual Py::PythonExtensionBase::~PythonExtensionBase(): Assertion `ob_refcnt == 0' failed.
Aborted (core dumped)

looks like commit 85af0c0#src/ft2font.cpp is the culprit

@mdboom
Copy link
Member

mdboom commented Aug 2, 2012

I can't reproduce this here, but it may be something unique about your system.

I believe that commit you reference fixes this bug (which I have seen before) rather than creates it. Are you sure you're running master and have rebuilt from scratch (by deleting the "build" directory before rebuilding)? If you're certain of that, have you tried building either of the parent commits of that commit to confirm that it works before and not after?

@sfabbro
Copy link
Author

sfabbro commented Aug 2, 2012

i can reproduce with matplotlib-1.1.1 and without -DNDEBUG. the git master actually seems to works.

it is confusing, because a fix was committed back in 2010 with:

b5ce842

but later on was overwritten with the commit refered in the first comment.

@mdboom
Copy link
Member

mdboom commented Aug 2, 2012

I see. Thanks for the additional info. I'll look at the 1.1.x branch and see what I can discover there.

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

The fix in b5ce842 was no longer needed following an update to PyCXX.

Strangely, I'm still unable to reproduce on 1.1.1 without -NDEBUG:

CFLAGS=-UNDEBUG python setup.py install

This sometimes happens when things don't get fully rebuilt after switching branches.

@sfabbro
Copy link
Author

sfabbro commented Aug 3, 2012

CXXFLAGS need to be set as well

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

Thanks -- just tried that. Due to a bug in how distutils handles CXXFLAGS, it doesn't actually matter, but for good measure it makes sense. Unfortunately, I'm still not able to reproduce.

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

What platform are you on?

@sfabbro
Copy link
Author

sfabbro commented Aug 3, 2012

i am on gentoo x86_64, but i did check on ubuntu 12.04 x86_64 to make sure it was not distro specific.
to reproduce from a vanilla matplotlib-1.1.1 tar ball, i do:

CXXFLAGS=-UNDEBUG CFLAGS=-UNDEBUG python setup.py build
cp doc/matplotlibrc .
PYTHONPATH=build/lib.linux-x86_64-2.7 python examples/pylab_examples/stix_fonts_demo.py

mdboom added a commit that referenced this pull request Aug 3, 2012
 stix_fonts_demo.py fails with bad refcount
@mdboom mdboom merged commit 8089e04 into matplotlib:v1.1.x Aug 3, 2012
@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

Right you are. The missing piece was the matplotlibrc from the doc directory.

With debugging turned on, it looks like those ob_refcnt-- operations are required on both 1.1.x and master. Thanks for finding this. Without debugging turned on, these are probably silently leaking.

1 similar comment
@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

Right you are. The missing piece was the matplotlibrc from the doc directory.

With debugging turned on, it looks like those ob_refcnt-- operations are required on both 1.1.x and master. Thanks for finding this. Without debugging turned on, these are probably silently leaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants