Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup: PEP8, PEP257 #10542

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
4 participants
@timhoffm
Copy link
Member

commented Feb 20, 2018

PR Summary

Minor code and docstring formatting changes to conform with PEP8 and PEP257.

if axis in ["both", "x"]:
locs = []
y1, y2 = self.axes.get_ylim()
#if self.axes.xaxis._gridOnMajor:
# if self.axes.xaxis._gridOnMajor:

This comment has been minimized.

Copy link
@anntzer

anntzer Feb 20, 2018

Contributor

seems quite clearly removable, below too

self._axisline_on = True

helper = kw.pop("grid_helper", None)

This comment has been minimized.

Copy link
@anntzer

anntzer Feb 20, 2018

Contributor

target 3.0 and make this a kwonly argument?

@anntzer
Copy link
Contributor

left a comment

minor additional improvements possible

@tacaswell tacaswell added this to the v3.0 milestone Feb 20, 2018

@timhoffm timhoffm force-pushed the timhoffm:minor-cleanup-pep8-pep257 branch from 86bc45e to 590d69b Feb 20, 2018

@timhoffm timhoffm force-pushed the timhoffm:minor-cleanup-pep8-pep257 branch from 590d69b to eb07c30 Feb 20, 2018

@jklymak

jklymak approved these changes Mar 9, 2018

@jklymak jklymak merged commit aadd0e0 into matplotlib:master Mar 9, 2018

7 of 8 checks passed

codecov/patch 25% of diff hit (target 50%)
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/project/library 67.35% (target 50%)
Details
codecov/project/tests 98.51% (+0.12%) compared to 254cdac
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@timhoffm timhoffm deleted the timhoffm:minor-cleanup-pep8-pep257 branch Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.