Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markers from Paths that consist of one line segment #10632

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
5 participants
@lpsinger
Copy link
Contributor

commented Feb 28, 2018

The elif clauses in Marker.set_marker needed to be reordered because any Python object that has a __len__ method is an instance of collections.Sized.

Before this change, the new unit test test_marker_path() would fail with this exception:

TypeError: 'Path' object does not support indexing
Support markers from Paths that consist of one line segment
The `elif` clauses in `Marker.set_marker` needed to be reordered
because any Python object that has a `__len__` method is an
instance of `collections.Sized`.
@phobson

phobson approved these changes Mar 2, 2018

@phobson phobson merged commit 79fb398 into matplotlib:master Mar 2, 2018

8 checks passed

ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/patch 77.77% of diff hit (target 50%)
Details
codecov/project/library 67.1% (target 50%)
Details
codecov/project/tests 98.37% (+<.01%) compared to 6bb5994
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@lpsinger lpsinger deleted the lpsinger:short-marker-path branch Mar 2, 2018

@QuLogic QuLogic added this to the v3.0 milestone Mar 2, 2018

@ImportanceOfBeingErnest

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

I think this fixes a bug and a regression to 1.x versions. Should be put in the 2.2 branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.