Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX/TST constrained_layout remove test8 duplication #10725

Merged

Conversation

Projects
None yet
3 participants
@jklymak
Copy link
Contributor

commented Mar 8, 2018

PR Summary

closes #10722

Had an extra copy of a test in test_constrainedlayout. Removed, and refactored the test a bit while there.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant

@jklymak jklymak added this to the v3.0 milestone Mar 8, 2018

@jklymak

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2018

I'll ping about this one - its a pretty quick review and will improve the test coverage stats.

@jklymak

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2018

ping

@anntzer anntzer merged commit bb337ad into matplotlib:master Mar 16, 2018

8 checks passed

ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project/library 68.58% (target 50%)
Details
codecov/project/tests 98.77% (+0.21%) compared to ef5d01a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@jklymak jklymak deleted the jklymak:fix-tst-constrainedlayout-badtest branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.