Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set data limits for Axes3DSubplot.plot when zdir=y or zdir=x #5742 #10728

Merged
merged 5 commits into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@Osarumwense
Copy link
Contributor

commented Mar 8, 2018

PR Summary

Currently Axes3DSubplot.plot does not set data limits on graphs when zdir=y or zdir=x. This pull request fixes this.

Issue: #5742

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
@WeatherGod

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

Ah, right! I never really figured this one out. I completely forgot about line_2d_to_3d doing a juggle internally, so it would completely make sense to do a juggle before calling autoscaling.

@WeatherGod WeatherGod added this to the v2.2.1 milestone Mar 9, 2018

@WeatherGod WeatherGod merged commit fa2a0d6 into matplotlib:master Mar 9, 2018

8 checks passed

ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project/library 68.82% (target 50%)
Details
codecov/project/tests 98.57% (+<.01%) compared to ef5d01a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@WeatherGod WeatherGod added the mplot3d label Mar 9, 2018

meeseeksdev bot pushed a commit that referenced this pull request Mar 9, 2018

jklymak added a commit that referenced this pull request Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.