Make grid accept alpha rcParam #1114

Merged
merged 2 commits into from Aug 23, 2012

Projects

None yet

3 participants

@dmcdougall
Member

This PR fixes #871

I should probably update the docstrings, too. And the default matplotlibrc file.

@dmcdougall
Member

Actually, the docstrings for axes, etc don't need updated. They already accepted the alpha kwarg. I should update the default matplotlibrc file, though.

$ find . -iname '*rc'
./doc/matplotlibrc
./doc/pyplots/matplotlibrc
./lib/matplotlib/mpl-data/matplotlibrc
./lib/matplotlib/tests/test_rcparams.rc

Which one of these do I need to update?

@pelson
Member
pelson commented Aug 21, 2012

Without any authority on the matter, I would say:

matplotlibrc.template
./lib/matplotlib/mpl-data/matplotlibrc
./doc/pyplots/matplotlibrc

While digging, I found lib/matplotlib/mpl-data/matplotlib.conf, can anyone tell me if this is still used?

Clearly this is highlighting an issue.

@pelson
Member
pelson commented Aug 21, 2012

I've made an issue for discussion on the various rc files and the conf file to keep the conversations separate from this PR.

@dmcdougall
Member

That's a great idea. Thanks.

I also found lib/matplotlib/mpl-data/matplotlib.conf.template too.

@dmcdougall
Member

Wait a sec, I found this in the .gitignore file:

# Things specific to this project #
###################################
lib/matplotlib/mpl-data/matplotlib.conf
lib/matplotlib/mpl-data/matplotlibrc
@dmcdougall dmcdougall Make grid accept alpha rcParam
Default grid.alpha is 1.0
c2b288b
@mdboom
Member
mdboom commented Aug 21, 2012

matplotlibrc.template is the one to update.

@dmcdougall
Member

Right, I will remove the update to the one under the docs directory. Thank you.

@pelson
Member
pelson commented Aug 21, 2012

Looks fine to me. +1

@mdboom mdboom merged commit b0393e9 into matplotlib:master Aug 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment