Handled baseline image folder identification for non matplotlib projects. #1177

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Member

pelson commented Aug 30, 2012

I'm working on a project which could really benefit from visual tests. So I thought I would just go ahead and use the decorators in mpl. Unfortunately, there seems to be just one place which hampers this. This PR removes that limitation (provided one structures their project in a similar way to mpl, which I do).

I am hopeful that this can go into 1.2, but if it doesn't it isn't a major disaster.

Member

WeatherGod commented Aug 30, 2012

This is a great idea! My only concern is that I am not familiar with the imp module, so I have no clue how it would behave in py2.6.

Member

pelson commented Aug 30, 2012

I have no clue how it would behave in py2.6

True. travis-ci can tell me what it thinks... :-)

This pull request fails (merged 8a94a23 into cf7618c).

@pelson pelson closed this Sep 7, 2012

Member

pelson commented Sep 17, 2012

Ahh. I can't remember why I closed this - I now have a need for this change. It appears that this change worked fine on travis-ci's python 2.6... @mdboom will we be able to get this into 1.2? If not, I will have to copy the testing/decorators module into my own project, which doesn't seem very desirable.

Owner

mdboom commented Sep 17, 2012

Seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment