Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

FIX undefined elements were used at several places in the mlab module #1183

merged 2 commits into from Sep 1, 2012


None yet
4 participants

NelleV commented Aug 31, 2012

There were undefined elements in the mlab module. it seems like this module is quite old and not very well tested in terms of coverage; It's also probably not widely used. I've fixed some of the problems but it might be worth it to do a huge clean up in the near future.

This pull request fails (merged cf720bc into cf7618c).

@pelson pelson and 1 other commented on an outdated diff Sep 1, 2012

@@ -2780,6 +2772,8 @@ def griddata(x,y,z,xi,yi,interp='nn'):
if xi.ndim == 1:
xi,yi = np.meshgrid(xi,yi)
# triangulate data
+ # FIXME delaunay is not imported here, and depends on the
+ # scipy.spatial packages; Scipy is not a dependency of matplotlib.
tri = delaunay.Triangulation(x,y)

pelson Sep 1, 2012


Delunay is a mpl sub-package, not the scipy delunay. However, there should be an absoute import of the package, i.e. import matplotlib.delunay rather than a relative one (can you check that for me?).


NelleV Sep 1, 2012


Correct. I don't know how I could have missed it... I've deleted the FIXME

This pull request fails (merged 5d67cef into cf7618c).


pelson commented Sep 1, 2012

Looks good.

@efiring efiring added a commit that referenced this pull request Sep 1, 2012

@efiring efiring Merge pull request #1183 from NelleV/mlab_fixes
FIX undefined elements were used at several places in the mlab module

@efiring efiring merged commit 9448ff2 into matplotlib:master Sep 1, 2012

1 check failed

default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment