Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler check for whether a Framework Python build is being used. #11851

Closed
wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 13, 2018

This check works even before an NSApp is started.

Simpler alternative to #11850. Basically the first stackoverflow answer for the question (https://stackoverflow.com/questions/15752390/how-to-tell-if-python-instance-was-compiled-as-framework), from a CPython core dev.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This check works even before an NSApp is started.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: MacOSX labels Aug 13, 2018
@anntzer anntzer added this to the v3.0 milestone Aug 13, 2018
@jklymak
Copy link
Member

jklymak commented Aug 13, 2018

Unfortunately, this doesnt' work w/ my Anaconda pythonw. That config variable is not set even if I use pythonw...

@anntzer
Copy link
Contributor Author

anntzer commented Aug 13, 2018

Looks like @efiring knows something about this per http://matplotlib.1069221.n5.nabble.com/Re-Anaconda-Support-OSX-why-not-make-python-invoke-the-framework-tp43793p43806.html :)
(and that anaconda's pythonw is not a real framework build but manually emulates one, whatever that means...)
Oh well.

@jklymak
Copy link
Member

jklymak commented Aug 13, 2018

Yeah, I guess anaconda does something funky. OTOH, I shudder to think what installing the framework build w/o anaconda would be like...

@anntzer
Copy link
Contributor Author

anntzer commented Aug 13, 2018

Isn't that just (for example) python.org's python? Anyways, the discussion is not very relevant, we're stuck with whatever anaconda did and #11850 seems better unless Apple plans to actually remove their deprecated features :p

@tacaswell tacaswell modified the milestones: v3.0, v3.1 Aug 19, 2018
@tacaswell
Copy link
Member

Moving this to 3.1 as I just merged #11850. I think this is inline with @anntzer 's last comment.

@tacaswell tacaswell removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 19, 2018
@jklymak
Copy link
Member

jklymak commented Nov 12, 2018

Closing this, as this approach won't work unfortunately...

@jklymak jklymak closed this Nov 12, 2018
@anntzer anntzer deleted the frameworkcheck branch November 12, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants