Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Small bugfixes to the new pickle support. #1191

Merged
merged 1 commit into from

3 participants

@pelson
Collaborator

Pickling support (#1175) finally made it onto master. We merged early to avoid major conflicts with such a big PR, therefore this PR implements some of the identified issues.

lib/matplotlib/tests/test_pickle.py
@@ -11,7 +11,11 @@
import cPickle as pickle
#import pickle
-from cStringIO import StringIO
+import sys
+if sys.version_info[0] >= 3:
@pelson Collaborator
pelson added a note

I've still not tested this, I took the lead from mathtext.py. Hopefully travis-ci will be helpful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@travisbot

This pull request fails (merged 9a8e4c8e into 92721ed).

@pelson
Collaborator

So I had a python3 extension to fix test_pickle in this PR. My approach wasn't immediately successful so I backtracked and have simplified this PR to just make this critical pgf fix.

Other PRs to follow.

@pelson pelson merged commit cadd152 into matplotlib:master

1 check was pending

Details default The Travis build is in progress
@travisbot

This pull request fails (merged 97b0f8e into 92721ed).

@pwuertz
Collaborator

About that python3 test fix:
pwuertz@8753aaa

The io module has been introduced in python 2.6, so the fix should be good for all supported versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 2, 2012
  1. @pelson
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/matplotlib/backends/backend_pgf.py
View
2  lib/matplotlib/backends/backend_pgf.py
@@ -611,7 +611,7 @@ def new_figure_manager(num, *args, **kwargs):
# main-level app (egg backend_gtk, backend_gtkagg) for pylab
FigureClass = kwargs.pop('FigureClass', Figure)
thisFig = FigureClass(*args, **kwargs)
- return new_figure_manager_given_figure(thisFig)
+ return new_figure_manager_given_figure(num, thisFig)
def new_figure_manager_given_figure(num, figure):
Something went wrong with that request. Please try again.