Small bugfixes to the new pickle support. #1191

Merged
merged 1 commit into from Sep 2, 2012

Conversation

Projects
None yet
3 participants
Member

pelson commented Sep 2, 2012

Pickling support (#1175) finally made it onto master. We merged early to avoid major conflicts with such a big PR, therefore this PR implements some of the identified issues.

@pelson pelson commented on an outdated diff Sep 2, 2012

lib/matplotlib/tests/test_pickle.py
@@ -11,7 +11,11 @@
import cPickle as pickle
#import pickle
-from cStringIO import StringIO
+import sys
+if sys.version_info[0] >= 3:
@pelson

pelson Sep 2, 2012

Member

I've still not tested this, I took the lead from mathtext.py. Hopefully travis-ci will be helpful here.

This pull request fails (merged 9a8e4c8e into 92721ed).

Member

pelson commented Sep 2, 2012

So I had a python3 extension to fix test_pickle in this PR. My approach wasn't immediately successful so I backtracked and have simplified this PR to just make this critical pgf fix.

Other PRs to follow.

@pelson pelson added a commit that referenced this pull request Sep 2, 2012

@pelson pelson Merge pull request #1191 from pelson/pickle_fix_1
Small bugfixes to the new pickle support.
cadd152

@pelson pelson merged commit cadd152 into matplotlib:master Sep 2, 2012

1 check was pending

default The Travis build is in progress
Details

This pull request fails (merged 97b0f8e into 92721ed).

Contributor

pwuertz commented Sep 2, 2012

About that python3 test fix:
pwuertz/matplotlib@8753aaa

The io module has been introduced in python 2.6, so the fix should be good for all supported versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment