Fix overwriting suptitle #1276

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@dmcdougall
Member

Fixes #1262.

Note, once the position is set, it can't be changed on a new call to suptitle. I think it might be a better idea to allow the user to change the position on subsequent calls to suptitle.

@dmcdougall
Member

Do we want a test for this? If not, this is good to go.

@efiring
Member
efiring commented Nov 5, 2012

Do we want the kwargs to be ignored on subsequent calls, as they will be in the present state of this PR?

@dmcdougall
Member

Eyes like a hawk. I will fix that. Thanks.

@dmcdougall
Member

I think that's better.

@dmcdougall dmcdougall referenced this pull request Jan 15, 2013
Merged

Fix suptitle #1663

@dmcdougall
Member

Since this is a bugfix, I opened a new pull request that targets v1.2.x. See #1663.

@dmcdougall dmcdougall closed this Jan 15, 2013
@pelson
Member
pelson commented Jan 16, 2013

Since this is a bugfix

Ah the old gray line.... 😄 - one could equally argue that you are extending previously designed behaviour and therefore this is an enhancement 😉.

Either way, as I've made clear before, I really hope it makes no difference and we can get on and get a v1.3 release (which IMHO is already feature packed) out.

@dmcdougall
Member

That's a fair point. In my opinion, the design before this change appears to overlook the issue of it not being overwritten on an update. In any case, mention of its behaviour in the docstring, at a minimum, should go into v1.2.1.

Though, as you've said, it probably makes no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment