Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.0.x pi #13491

Closed
wants to merge 2 commits into from
Closed

V3.0.x pi #13491

wants to merge 2 commits into from

Conversation

tacaswell
Copy link
Member

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.0.3 milestone Feb 23, 2019
@tacaswell
Copy link
Member Author

oh, interesting, because I opened this PR against @ivanov 's branch I did not get "commiters can push" on by default which makes lots of sense (other wise I could attack any branch of anyone who has forked a repo I control).

I'm going to close this and open another one from a branch I have pushed some more commits to.

@tacaswell tacaswell closed this Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants