Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _warn_external correctly report warnings arising from tests. #13795

Merged
merged 1 commit into from Apr 17, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 29, 2019

Before the PR:

$ pytest lib/matplotlib/tests/test_cbook.py::test_is_hashable
<elided>
lib/matplotlib/tests/test_cbook.py::test_is_hashable
  .../site-packages/_pytest/python.py:166: MatplotlibDeprecationWarning:
  The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead.
    testfunction(**testargs)

-- Docs: https://docs.pytest.org/en/latest/warnings.html

After

$ pytest lib/matplotlib/tests/test_cbook.py::test_is_hashable
<elided>
lib/matplotlib/tests/test_cbook.py::test_is_hashable
  .../lib/matplotlib/tests/test_cbook.py:22: MatplotlibDeprecationWarning:
  The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead.
    assert cbook.is_hashable(s)

lib/matplotlib/tests/test_cbook.py::test_is_hashable
  .../lib/matplotlib/tests/test_cbook.py:25: MatplotlibDeprecationWarning:
  The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead.
    assert not cbook.is_hashable(lst)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@NelleV
Copy link
Member

NelleV commented Apr 10, 2019

It would be nice to have unit tests.

Before the PR:
```
$ pytest lib/matplotlib/tests/test_cbook.py::test_is_hashable
<elided>
lib/matplotlib/tests/test_cbook.py::test_is_hashable
  .../site-packages/_pytest/python.py:166: MatplotlibDeprecationWarning:
  The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead.
    testfunction(**testargs)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
```
After
```
$ pytest lib/matplotlib/tests/test_cbook.py::test_is_hashable
<elided>
lib/matplotlib/tests/test_cbook.py::test_is_hashable
  .../lib/matplotlib/tests/test_cbook.py:22: MatplotlibDeprecationWarning:
  The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead.
    assert cbook.is_hashable(s)

lib/matplotlib/tests/test_cbook.py::test_is_hashable
  .../lib/matplotlib/tests/test_cbook.py:25: MatplotlibDeprecationWarning:
  The is_hashable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use isinstance(..., collections.abc.Hashable) instead.
    assert not cbook.is_hashable(lst)
```
@anntzer
Copy link
Contributor Author

anntzer commented Apr 11, 2019

sure, here it is.

@dstansby dstansby added this to the v3.2.0 milestone Apr 16, 2019
@timhoffm timhoffm merged commit e652c8b into matplotlib:master Apr 17, 2019
@anntzer anntzer deleted the warnexternal-tests branch April 17, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants