Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing Path to ps backend when text.usetex rc is True. #13925

Merged
merged 1 commit into from Apr 14, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 11, 2019

... and misc. cleanups to test_backend_ps (more pathlib + remove an
unnecessary rc_context() as tests always reset the rcs at exit).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... and misc. cleanups to test_backend_ps (more pathlib + remove an
unnecessary rc_context() as tests always reset the rcs at exit).
@WeatherGod
Copy link
Member

How does that one particular test get its context reset automatically? It has no decorators.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 11, 2019

with the autouse fixture at https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/testing/conftest.py#L17.

note, for example, that the test immediately above (test_savefig_to_stringio) also modifies the rcparams but does not bother to restore them.

@timhoffm timhoffm added this to the v3.2.0 milestone Apr 14, 2019
@timhoffm timhoffm merged commit efbd153 into matplotlib:master Apr 14, 2019
@anntzer anntzer deleted the test_backend_ps branch April 14, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants