Skip to content

Add tests to mpl toolkits #1422

Closed
wants to merge 4 commits into from

6 participants

@jenshnielsen
Matplotlib Developers member

This pull request adds infrastructure for testing of mpl_toolkits and a single test of axesgrid1 to demonstrate. The test is copied from a axesgrid1 example. If this is ok we should add more tests.

Right now "python tests.py" runs all tests from mpl and the toolkits.
While matplotlib.test() only runs the matplotlib tests and mpl_toolkits.test() runs the tests of the toolkits only.

So what do you think. Should tests be added to the toolkits? If yes any preferences to how the tests should be integrated into the mpl test suite.

@pelson
Matplotlib Developers member
pelson commented Oct 22, 2012

Thanks for doing this work @jenshnielsen .
I wonder if it is time to split this toolkit out of the core repository so that it can move forward at its own pace, with its own tests, without us having to worry about the storage overhead that having another set of unit test images is inevitably going to cause. What do other think?

@leejjoon will obviously want visibility of this PR.

Thanks again,

@mdboom
Matplotlib Developers member
mdboom commented Oct 22, 2012

I'm generally in favor of moving out the toolkits to their own repositories. I think in general that's the right approach, and doing so is much easier under github than it was on Sourceforge/SVN. However, I wonder if some users will be inconvenienced by now needing to install multiple packages (and needing to tell their colleagues to do so). We should probably consider this case as part of MEP11 and find a way to easily install these toolkits, even on, e.g. Windows, where pip/easy_install may not be installed.

Also, do we want to do the same with mplot3d?

In the short term, I don't think this PR needs to be held up by that decision -- it's perfectly fine to merge this for now and separate the toolkit out later.

@WeatherGod
Matplotlib Developers member
@mdboom
Matplotlib Developers member
mdboom commented Oct 22, 2012

I wasn't very clear in my first post -- I think we're more in agreement than I let on.

I think that while these toolkits are experimental, it makes sense to try to keep them more independent, so it's easier to update them at a different rate than the matplotlib core. But the end game (ideally, at least for things that are general-purpose, unlike basemap which is much more domain-specific) is to merge them into the core. I see it as rather analogous to most of the newer modules in the Python standard library -- they begin life as their own independent projects with a much higher API-change rate than Python itself, but then once they've settled down and stabilized their API, they are considered for inclusion in the core.

But perhaps given that consensus is brewing around having a faster release cycle for matplotlib, keeping the toolkits where they are now does in fact make the most sense.

@jenshnielsen
Matplotlib Developers member

I have added some more tests of the axesgrid1 toolkit and updated the test documentation to reflect this.
Is there anything else that needs to be done before this can be merged?

@Tillsten
Tillsten commented Mar 4, 2013

Travis is still thinking these tests are fine, so merge?

@pelson
Matplotlib Developers member
pelson commented Mar 5, 2013

The PR doesn't merge without conflict, so it would be good to rebase.

@Tillsten
Tillsten commented Mar 7, 2013

Ok, i'll try a rebase this WE.

@pelson
Matplotlib Developers member
pelson commented Apr 18, 2013

In need of a rebase. I also wonder whether, given this is a mpl toolkit and does not modify any of the backend rendering processes, if we can just test pngs rather than all 3 formats...

In general though, 👍

@mdboom
Matplotlib Developers member
mdboom commented Apr 18, 2013

Yes, 👍. wrt to @pelson's comment about file formats, I tend to agree unless there are any specific tests where cross-backend things are an issue. Keeping the dist size and test run times low is getting to be a real priority.

@dmcdougall
Matplotlib Developers member

I agree with @pelson here. It would be nice to have this merged.

@mdboom
Matplotlib Developers member
mdboom commented Jun 17, 2013

@jenshnielsen: Would you be willing to get this rebased in line with the current v1.3.x branch?

@jenshnielsen
Matplotlib Developers member

I will look into it today or tomorrow.

@jenshnielsen jenshnielsen referenced this pull request Jun 18, 2013
Closed

Test toolkits rebase #2135

@jenshnielsen
Matplotlib Developers member

Closing this since there now is a rebase on the v1.3.x branch

@jenshnielsen jenshnielsen referenced this pull request Jan 23, 2014
Closed

Test toolkits rebase #2758

@jenshnielsen jenshnielsen deleted the jenshnielsen:test_toolkits branch Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.