Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

PEP8-compliance on axes.py (patch 1 / 4) #1464

Merged
merged 1 commit into from Nov 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

NelleV commented Nov 8, 2012

Here is the first patch on pep8 compliance of the axes.py module.

Cheers,
N

@pelson pelson commented on the diff Nov 8, 2012

lib/matplotlib/axes.py
@@ -968,10 +976,6 @@ def cla(self):
self._shared_x_axes.clean()
self._shared_y_axes.clean()
- def get_frame(self):
- raise AttributeError('Axes.frame was removed in favor of Axes.spines')
@pelson

pelson Nov 8, 2012

Member

I agree with this change. Just want to point it out to others.

@NelleV

NelleV Nov 8, 2012

Contributor

For information, this method was defined twice.

@pelson pelson commented on the diff Nov 8, 2012

lib/matplotlib/axes.py
@@ -3226,6 +3236,7 @@ def dist(a):
artists = self.lines + self.patches + self.texts
if callable(among):
+ # FIXME test is not defined
@pelson

pelson Nov 8, 2012

Member

Would you mind opening a bug for this one?

@NelleV

NelleV Nov 8, 2012

Contributor

I've opened a ticket: #1465

@pelson pelson commented on the diff Nov 8, 2012

lib/matplotlib/axes.py
@@ -6089,9 +6092,6 @@ def scatter(self, x, y, s=20, c='b', marker='o', cmap=None, norm=None,
'''replace "faceted=False" with "edgecolors='none'"''',
DeprecationWarning) #2008/04/18
- sym = None
@pelson

pelson Nov 8, 2012

Member

Yep. This is good. Thanks.

@pelson pelson commented on the diff Nov 8, 2012

lib/matplotlib/axes.py
@@ -8825,7 +8822,6 @@ def get_tightbbox(self, renderer, call_axes_locator=True):
compared to the axes bbox.
"""
- artists = []
Member

pelson commented Nov 8, 2012

👍

pelson added a commit that referenced this pull request Nov 8, 2012

Merge pull request #1464 from NelleV/pep8_axes_1
PEP8-compliance on axes.py (patch 1 / 4)

@pelson pelson merged commit 3a9a782 into matplotlib:master Nov 8, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment