Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

use an imagemap for the "fork me on github" ribbon #1468

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

ivanov commented Nov 9, 2012

Right now, the ribbon on the front page blocks out the possiblity of clicking
on the "Index" link, because the "Fork me on Github" link is on top of it.

I've rectified this by providing an imagemap, which only makes part of the
image clickable as a link. I've verified that it works under Firefox, Chromium,
and w3m.

I have also moved the ribbon from being only on the front page, to
appearing on all pages, since that has the potential of inviting
contributors more actively, as most people won't spend much time on the
index page, once they are actually using matplotlib, whereas they will
be peaking at the gallery, as well as the api docs, etc.

I got the numbers for the ribbon from here: susestudio/studio-help#20, but then
adjusted them so that the full upper left triangle would be clickable, and not
just the ribbon.

Also, can someone tell me if I should be filing this only against master, only against 1.2.x, or both?

@ivanov ivanov use an imagemap for the "fork me on github" ribbon
Right now, the ribbon on the front page blocks out the possiblity of clicking
on the "Index" link, because the "Fork me on Github" link is on top of it.

I've rectified this by providing an imagemap, which only makes part of the
image clickable as a link. I've verified that it works under Firefox, Chromium,
and w3m.

I have also moved the ribbon from being only on the front page, to
appearing on all pages, since that has the potential of inviting
contributors more actively, as most people won't spend much time on the
index page, once they are actually using matplotlib, whereas they will
be peaking at the gallery, as well as the api docs, etc.

I got the numbers for the ribbon from here: susestudio/studio-help#20, but then
adjusted them so that the full upper left triangle would be clickable, and not
just the ribbon.
20ed996
Member

pelson commented Nov 9, 2012

Thanks @ivanov - nice solution to the problem!

I think we probably would want to do this against v1.2.x, would you mind changing the PR appropriately?

Cheers,

Member

ivanov commented Nov 10, 2012

@pelson - did this in #1474, but it seems that this change should be applied both to master and v1.2.x...

...unless I'm severely confused about how are we working now - will things from 1.2.x be merged back into master?

Edit: also, I didn't find a way to switch which branch a PR is applied against, so I had to open a new one anyway.

Member

dmcdougall commented Nov 10, 2012

will things from 1.2.x be merged back into master?

Yup.

Member

ivanov commented Nov 10, 2012

ok, thanks for clarifying, @dmcdougall, closing this in favor of #1474, then.

@ivanov ivanov closed this Nov 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment