Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate axis_artist.BezierPath. #14786

Merged
merged 1 commit into from Jul 17, 2019
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 15, 2019

Throughout the library the advice to draw an arbitrary Path object is to
use PathPatch; there's no reason to do differently with a one-off class
in axisartist.

Technically that's an API break because the type of AxisArtist.line
changed, but most common APIs do overlap (e.g. set_color, which is
exercised by the tests) so I'm not going to bother with a deprecation
period which would be quite painful (likely involving a global rcParam
controlling the switch from the old API to the new one).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Throughout the library the advice to draw an arbitrary Path object is to
use PathPatch; there's no reason to do differently with a one-off class
in axisartist.

Technically that's an API break because the type of AxisArtist.line
changed, but most common APIs do overlap (e.g. `set_color`, which is
exercised by the tests) so I'm not going to bother with a deprecation
period which would be quite painful (likely involving a global rcParam
controlling the switch from the old API to the new one).
@efiring efiring merged commit 9f1c730 into matplotlib:master Jul 17, 2019
@anntzer anntzer deleted the bezierpath branch July 17, 2019 08:44
@QuLogic QuLogic added this to the v3.2.0 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants