Remove dead code in patches #1480

Merged
merged 1 commit into from Nov 15, 2012

Conversation

Projects
None yet
2 participants
@dmcdougall
Member

dmcdougall commented Nov 11, 2012

The pad variable was never used in this function, so it is being
removed. It also depended on a kwarg, which was also not used.

Remove dead code in patches
The pad variable was never used in this function, so it is being
removed. It also depended on a kwarg, which was also not used.
@WeatherGod

This comment has been minimized.

Show comment Hide comment
@WeatherGod

WeatherGod Nov 11, 2012

Member

Agreed. I can't find anyplace where the leadingspaces kwarg was ever used. I will wait a little bit to see if anyone else can find anyplace where it was used. If so, we may have to do a deprecation process, but that might be overkill.

Member

WeatherGod commented Nov 11, 2012

Agreed. I can't find anyplace where the leadingspaces kwarg was ever used. I will wait a little bit to see if anyone else can find anyplace where it was used. If so, we may have to do a deprecation process, but that might be overkill.

@dmcdougall

This comment has been minimized.

Show comment Hide comment
@dmcdougall

dmcdougall Nov 14, 2012

Member

@WeatherGod I think you're right; deprecation is overkill for this -- shall I go ahead and merge it?

Member

dmcdougall commented Nov 14, 2012

@WeatherGod I think you're right; deprecation is overkill for this -- shall I go ahead and merge it?

@WeatherGod

This comment has been minimized.

Show comment Hide comment
@WeatherGod

WeatherGod Nov 15, 2012

Member

I think so. Better to do this now and let it bake for the entire dev
cycle, maximizing the chance to see if it trips anything.

Member

WeatherGod commented Nov 15, 2012

I think so. Better to do this now and let it bake for the entire dev
cycle, maximizing the chance to see if it trips anything.

dmcdougall added a commit that referenced this pull request Nov 15, 2012

@dmcdougall dmcdougall merged commit 0287036 into matplotlib:master Nov 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment