Documentation update for specgram #1489

Merged
merged 2 commits into from Nov 24, 2012

Projects

None yet

3 participants

@gitj
gitj commented Nov 12, 2012

Mention that plotted data is in dB

In response to:
http://matplotlib.1069221.n5.nabble.com/specgram-bug-td39730.html

@gitj gitj Update documentation of specgram
Mention that plotted data is in dB
016f644
@ivanov
Member
ivanov commented Nov 12, 2012

looks good to me, but when I saw that thread, I ended up adding a note by the return value, as well as a comment in the code. Can you cherrypick from ivanov/matplotlib@5b52fc3 ?

On your master branch, this should do the trick:

git remote add ivanov git://github.com/ivanov/matplotlib.git
git fetch ivanov
git cherry-pick 5b52fc30fa49
@pelson
Member
pelson commented Nov 13, 2012

@ivanov : you might already know, but it is possible to submit a PR against @gitj 's branch.

@gitj
gitj commented Nov 13, 2012

Sorry to be difficult, but I didn't actually clone this to a local
machine; I simply forked it and used github's online editor to edit
axes.py in place. I just took a look around to see if there was a way
to add a remote etc online, but doesn't look like it. Can I just copy
your edits into this pull request manually?

On Mon, Nov 12, 2012 at 1:42 PM, Paul Ivanov notifications@github.com wrote:

looks good to me, but when I saw that thread, I ended up adding a note by
the return value, as well as a comment in the code. Can you cherrypick from
ivanov/matplotlib@5b52fc3 ?

On your master branch, this should do the trick:

git remote add ivanov git://github.com/ivanov/matplotlib.git
git fetch ivanov
git cherry-pick 5b52fc3


Reply to this email directly or view it on GitHub.

@ivanov
Member
ivanov commented Nov 13, 2012

@pelson yes, I was just trying to avoid an extra merge commit, but now submitted a PR against @gitj branch, though had some trouble with that, because my Pull Request drop down menu did not list @gitj/matplotlib in the possible base repos.

The workaround I used was to select one of the available base repos, noting the URL change, and then manually changing the URL with gitj in the appropriate place. I submitted this information to github support, so hopefully the will track it down.

@gitj, you should be able to merge my PR against your branch, which will then percolate to this PR.

@ivanov
Member
ivanov commented Nov 13, 2012

ok, @gitj caught an error I made in describing the return value, so gitj/matplotlib#1 is closed now. So I'm happy with this now :)

@pelson
Member
pelson commented Nov 15, 2012

👍 looks good to me. Thanks @ivanov & @gitj!

@ivanov
Member
ivanov commented Nov 24, 2012

it's never a bad time to have better docs, merging this one, thanks again, @gitj!

@ivanov ivanov merged commit a1f8b4e into matplotlib:master Nov 24, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment