Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

DOC: github ribbon does not cover up index link #1523

Merged
merged 1 commit into from

3 participants

@ivanov
Collaborator

thanks to @jenshnielsen for spotting the fact that the previous "solution"
didn't actually work as intended in #1474. This PR fixes the issue of the ribbon covering up links under it.

Before this commit, hovering over the word "index" did not activate the link, and the ribbon looked like this:

Now, the ribbon has moved, and hovering over "index" works as intended.

Also, I've given a title to the GitHub ribbon link, so hovering over it also displays a little tooltip, like so

@ivanov ivanov DOC: github ribbon does not cover up index link
thanks @jenshnielsen for spotting the fact that the previous "solution"
didn't actually work as intended.
68a89e4
@jenshnielsen

Thanks. +1

@dmcdougall
Collaborator

Thanks @ivanov.

@dmcdougall dmcdougall merged commit a093579 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 22, 2012
  1. @ivanov

    DOC: github ribbon does not cover up index link

    ivanov authored
    thanks @jenshnielsen for spotting the fact that the previous "solution"
    didn't actually work as intended.
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 6 deletions.
  1. +6 −6 doc/_templates/layout.html
View
12 doc/_templates/layout.html
@@ -32,17 +32,17 @@
<!-- End Piwik Tag -->
<link rel="shortcut icon" href="_static/favicon.ico">
+<!-- The "Fork me on github" ribbon -->
+<img style="float: right; margin-bottom: -40px; top: 0; right: 0; border: 0;" src="https://s3.amazonaws.com/github/ribbons/forkme_right_orange_ff7600.png" usemap="#ribbonmap"/>
+<map name="ribbonmap">
+ <area shape="poly" coords="15,0,148,-1,148,135" href="https://github.com/matplotlib/matplotlib" title="Fork me on GitHub" />
+</map>
+
<div style="background-color: white; text-align: left; padding: 10px 10px 15px 15px">
<a href="{{ pathto('index') }}"><img src="{{
pathto("_static/logo2.png", 1) }}" border="0" alt="matplotlib"/></a>
</div>
-<!-- The "Fork me on github" ribbon -->
-<img style="position: absolute; top: 0; right: 0; border: 0;" src="https://s3.amazonaws.com/github/ribbons/forkme_right_orange_ff7600.png" usemap="#ribbonmap"/>
-<map name="ribbonmap">
- <area shape="poly" coords="20,2,148,-1,148,135" href="https://github.com/matplotlib/matplotlib" alt="Fork me on GitHub" />
-</map>
-
{{ super() }}
{% endblock %}
Something went wrong with that request. Please try again.