DOC: github ribbon does not cover up index link #1523

Merged
merged 1 commit into from Nov 26, 2012

Conversation

Projects
None yet
3 participants
Member

ivanov commented Nov 22, 2012

thanks to @jenshnielsen for spotting the fact that the previous "solution"
didn't actually work as intended in #1474. This PR fixes the issue of the ribbon covering up links under it.

Before this commit, hovering over the word "index" did not activate the link, and the ribbon looked like this:

Now, the ribbon has moved, and hovering over "index" works as intended.

Also, I've given a title to the GitHub ribbon link, so hovering over it also displays a little tooltip, like so

@ivanov ivanov DOC: github ribbon does not cover up index link
thanks @jenshnielsen for spotting the fact that the previous "solution"
didn't actually work as intended.
68a89e4
Owner

jenshnielsen commented Nov 22, 2012

Thanks. +1

Member

dmcdougall commented Nov 26, 2012

Thanks @ivanov.

@dmcdougall dmcdougall added a commit that referenced this pull request Nov 26, 2012

@dmcdougall dmcdougall Merge pull request #1523 from ivanov/gh-ribbon-fixed
DOC: github ribbon does not cover up index link
a093579

@dmcdougall dmcdougall merged commit a093579 into matplotlib:v1.2.x Nov 26, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment