Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make `rc_context` available via pyplot interface #1534

Merged
merged 2 commits into from Jan 17, 2013

Conversation

Projects
None yet
4 participants
Member

ivanov commented Nov 26, 2012

pyplot already exposes rc, rcParams, and rcdefaults.

The new functionality available via rc_context is a nice complement to these, so I don't see a reason why we shouldn't make it available via pyplot

Member

pelson commented Nov 26, 2012

👍 Thanks @ivanov - good idea. I'm not sure this change gets documented in the pyplot command list (that may be entirely consistent with the other rc* like commands) - if you agree that it would make sense to document it, would you mind building the docs to see?

Cheers,

Member

pelson commented Nov 26, 2012

Note: The travis build failed (not the tests) - would you mind going to the build page and "re-building" (on the little settings button to the right of the main tabs).

Member

dmcdougall commented Nov 26, 2012

@pelson I don't see the 'rebuild' option under the little setting button. Is it only available to the author of the PR?

Member

pelson commented Nov 26, 2012

Is it only available to the author of the PR?

Yeah I think so (otherwise I would have done it for @ivanov 😄). Note: I'm not actually confident that this is just a build failiure - it could be an actual failure introduced into mpl in previous commits...)

Member

dmcdougall commented Nov 26, 2012

Is it only available to the author of the PR?

Yeah I think so (otherwise I would have done it for @ivanov ).

Ok, that's cool. I was trying to ascertain whether I was retarded or blind. It turns out the answer is 'neither', so that's a good start to the week.

Note: I'm not actually confident that this is just a build failiure - it could be an actual failure introduced into mpl in previous commits...)

That's worrying. I just merged something with those build failures present. It seems to be failing on the numpy build, though, doesn't it?

Member

ivanov commented Nov 26, 2012

Is it only available to the author of the PR?

Yeah I think so (otherwise I would have done it for @ivanov ).

Ok, that's cool. I was trying to ascertain whether I was retarded or blind. It turns out the answer is 'neither', so that's a good start to the week.

Well, I don't seem to have had the same fortune. I can't find the rebuild button, and only see a "Status Images" option in the little settings gear.

It seems to be failing on the numpy build, though, doesn't it?

That's what it looks like to me, as well.

Member

ivanov commented Dec 5, 2012

I'm not sure this change gets documented in the pyplot command list

it didn't before, now it does.

(that may be entirely consistent with the other rc* like commands)

rc and rcdefaults was documented in pyplot's documentation, using the same trick I employed (see below)

if you agree that it would make sense to document it, would you mind building the docs to see?

@pelson , I agree that it makes sense to document it. I added a stub rc_context function to make it show up in pyplot's docs. I fiddled around for about an hour to try to figure out some other way for it to show up without such tomfoolery, but was not successful. It appears that this was also the fate that the plain old rc function saw, as well.

Owner

mdboom commented Jan 16, 2013

Is this ready to go? It needs a rebase, but other than that, it looks fine to me.

Member

dmcdougall commented Jan 16, 2013

Looks fine to me too, but @ivanov has been quiet lately. He's probably busy. I can merge this by hand if nobody minds.

@dmcdougall dmcdougall merged commit 0110347 into matplotlib:master Jan 17, 2013

Member

dmcdougall commented Jan 17, 2013

See 5ac976f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment