Geo projections getting clobbered by 2to3 when used when python3 #1555

Merged
merged 1 commit into from Dec 4, 2012

Projects

None yet

5 participants

@joferkington
Contributor

projections/geo.py uses long as a variable name in many places. This is replaced with int by 2to3, which leads to problems (e.g. foo = int * bar instead of foo = long * bar).

Steps to reproduce:

  1. Install matplotlib with python3.x
  2. Run examples/api/custom_projection_example.py
  3. Mouse over the plot (or anything else that will call an inverse geo projection)
Owner
efiring commented Dec 4, 2012

Looks good to me. "lon" and "lat" is much nicer than "long" and "lat" anyway.

Member

Woah. Nice catch, @joferkington! This PR looks fine to me too. I'll merge this tomorrow. Thanks again.

Member
pelson commented Dec 4, 2012

👍

Owner
mdboom commented Dec 4, 2012

Thanks. This should be cherry-picked for v1.2.x.

Member

Merging.

@mdboom Sure thing.

@dmcdougall dmcdougall merged commit e5b0042 into matplotlib:master Dec 4, 2012

1 check passed

default The Travis build passed
Details
Member

Cherry-pickled: 40d28e0

Contributor

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment