Workaround for QT cursor bug in dock areas #1559

Merged
merged 1 commit into from Dec 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

ChrisBeaumont commented Dec 4, 2012

Someone pointed out to me that the change in #1433 doesn't work when plots are embedded within QDockAreas (the cursor never changes). This is probably related to the Qt bug discussed here.

To reproduce the issue, under MPL 1.2.0: https://gist.github.com/4208745

This PR sets the cursor at a different level in the widget hierarchy, and seems to sidestep the problem.

Note that I haven't checked whether this change breaks the original problem addressed by #1404

Member

dmcdougall commented Dec 5, 2012

Cheers @ChrisBeaumont. I can confirm this fixes the issue. Merging.

dmcdougall added a commit that referenced this pull request Dec 5, 2012

Merge pull request #1559 from ChrisBeaumont/master
Workaround for QT cursor bug in dock areas

@dmcdougall dmcdougall merged commit 78cfcbe into matplotlib:master Dec 5, 2012

1 check passed

default The Travis build passed
Details
Member

dmcdougall commented Dec 5, 2012

This is a pretty nice fix and it's a ridiculously tiny change. @mdboom Can I cherry-plonk this into v1.2.x?

Owner

mdboom commented Dec 5, 2012

Yes: I think this makes sense to put on 1.2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment