Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

PEP8-compliance on axes.py (patch 4 / 4) #1564

Merged
merged 1 commit into from Dec 6, 2012

Conversation

Projects
None yet
3 participants
Contributor

NelleV commented Dec 5, 2012

Here is the last patch on the pep8 compliance of the axes.py module.

Cheers,
N

@dmcdougall dmcdougall commented on the diff Dec 5, 2012

lib/matplotlib/axes.py
y, x = np.nonzero(nonzero)
- if marker is None: marker = 's'
- if markersize is None: markersize = 10
+ if marker is None:
+ marker = 's'
+ if markersize is None:
+ markersize = 10
@dmcdougall

dmcdougall Dec 5, 2012

Member

Hmm, magic numbers like this are probably dealt with a better way. Not suggesting it is fixed in this PR, just thought I would point it out.

Member

dmcdougall commented Dec 5, 2012

+1

@pelson pelson commented on the diff Dec 6, 2012

lib/matplotlib/axes.py
@@ -8152,19 +8159,20 @@ def hist(self, x, bins=10, range=None, normed=False, weights=None,
# We will handle the normed kwarg within mpl until we
# get to the point of requiring numpy >= 1.5.
hist_kwargs = dict(range=bin_range)
- if np.__version__ < "1.3": # version 1.1 and 1.2
+ if np.__version__ < "1.3": # version 1.1 and 1.2
@pelson

pelson Dec 6, 2012

Member

For another PR: The numpy minimum version for mpl 1.2 is 1.4, so we can remove this.

@NelleV

NelleV Dec 6, 2012

Contributor

I'm working on a PR to remove deprecated stuff from this module; There's also something that was deprecated in 2010. I'm guessing that could also be removed (it was in 0.99).

Member

pelson commented Dec 6, 2012

👍

@pelson pelson added a commit that referenced this pull request Dec 6, 2012

@pelson pelson Merge pull request #1564 from NelleV/pep8_axes_4
PEP8-compliance on axes.py (patch 4 / 4)
dfe98aa

@pelson pelson merged commit dfe98aa into matplotlib:master Dec 6, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment