Make font_manager ignore KeyErrors for bad fonts #1604

Merged
merged 1 commit into from Dec 17, 2012

Conversation

Projects
None yet
2 participants
@dmcdougall
Member

dmcdougall commented Dec 17, 2012

Fixes #1601.

@dmcdougall

This comment has been minimized.

Show comment Hide comment
@dmcdougall

dmcdougall Dec 17, 2012

Member

There are other try/except blocks in the file that do:

except:

and not even

except Exception:.

This should probably be updated. Perhaps in a different pull request.

Member

dmcdougall commented Dec 17, 2012

There are other try/except blocks in the file that do:

except:

and not even

except Exception:.

This should probably be updated. Perhaps in a different pull request.

@mdboom

This comment has been minimized.

Show comment Hide comment
@mdboom

mdboom Dec 17, 2012

Member

I agree about the other empty try / except blocks -- but that can be a separate PR. This fixes a real issue (in #1601).

Member

mdboom commented Dec 17, 2012

I agree about the other empty try / except blocks -- but that can be a separate PR. This fixes a real issue (in #1601).

@dmcdougall

This comment has been minimized.

Show comment Hide comment
@dmcdougall

dmcdougall Dec 17, 2012

Member

@mdboom That's what I thought. In that case this is ready to go. The Travis failure was a git clone timeout on Python 3.1, so nothing to worry about. The tests pass on Python versions 2.{6,7} and 3.2.

Member

dmcdougall commented Dec 17, 2012

@mdboom That's what I thought. In that case this is ready to go. The Travis failure was a git clone timeout on Python 3.1, so nothing to worry about. The tests pass on Python versions 2.{6,7} and 3.2.

mdboom added a commit that referenced this pull request Dec 17, 2012

Merge pull request #1604 from dmcdougall/fix_badfonts
Make font_manager ignore KeyErrors for bad fonts

@mdboom mdboom merged commit 158cf33 into matplotlib:v1.2.x Dec 17, 2012

1 check failed

default The Travis build failed
Details
@dmcdougall

This comment has been minimized.

Show comment Hide comment
@dmcdougall

dmcdougall Dec 17, 2012

Member

Cheers @mdboom!

Member

dmcdougall commented Dec 17, 2012

Cheers @mdboom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment