Make font_manager ignore KeyErrors for bad fonts #1604

Merged
merged 1 commit into from Dec 17, 2012

Projects

None yet

2 participants

@dmcdougall
Matplotlib Developers member

Fixes #1601.

@dmcdougall
Matplotlib Developers member

There are other try/except blocks in the file that do:

except:

and not even

except Exception:.

This should probably be updated. Perhaps in a different pull request.

@mdboom
Matplotlib Developers member

I agree about the other empty try / except blocks -- but that can be a separate PR. This fixes a real issue (in #1601).

@dmcdougall
Matplotlib Developers member

@mdboom That's what I thought. In that case this is ready to go. The Travis failure was a git clone timeout on Python 3.1, so nothing to worry about. The tests pass on Python versions 2.{6,7} and 3.2.

@mdboom mdboom merged commit 158cf33 into matplotlib:v1.2.x Dec 17, 2012

1 check failed

Details default The Travis build failed
@dmcdougall
Matplotlib Developers member

Cheers @mdboom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment