Legend: Also calc the bbox of the legend when the frame is not drawn. (1.2.x) #1617

Merged
merged 1 commit into from Jan 16, 2013

Conversation

Projects
None yet
3 participants
Owner

jenshnielsen commented Dec 20, 2012

This should fix #1586

Owner

jenshnielsen commented Dec 20, 2012

One could also add a test however this must be against master since the bbox_tight tests are only there.

Owner

jenshnielsen commented Dec 20, 2012

The Travis failure is not relevant. It fails to install nose on Python3.1

Member

dmcdougall commented Dec 30, 2012

Why must the test only be added to the master branch? Worst case scenario is you add a test in v1.2.x and one of the developers merging v1.2.x into master sees a merge conflict. Am I missing something?

Owner

jenshnielsen commented Dec 31, 2012

The existing test for bbox_tigth are only on the master branch and this test would most naturally be done on top of
this one. The tests need to option to pass bbox_inches to the savefig command which was added to master only
in 45fa53d ect. from #1420

Owner

mdboom commented Jan 16, 2013

I see. I'll merge this and then merge it to master, and fix any tests if necessary.

@mdboom mdboom added a commit that referenced this pull request Jan 16, 2013

@mdboom mdboom Merge pull request #1617 from jenshnielsen/legend_bbox
Legend: Also calc the bbox of the legend when the frame is not drawn. (1.2.x)
5e02f50

@mdboom mdboom merged commit 5e02f50 into matplotlib:v1.2.x Jan 16, 2013

1 check failed

default The Travis build failed
Details

jenshnielsen deleted the jenshnielsen:legend_bbox branch Aug 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment