Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

implemented inverse transform for Mollweide axes #1624

Merged
merged 4 commits into from Jan 4, 2013

Conversation

Projects
None yet
4 participants
Contributor

lpsinger commented Dec 27, 2012

This patch adds an inverse transform to the class matplotlib.projections.geo.MollweideAxes.

Member

pelson commented Dec 28, 2012

Looks good to me. I'd want to check the numerical accuracy of forward -> inverse -> forward before merging, but I have no problems with this in principle. Good stuff @lpsinger!

lpsinger added some commits Dec 29, 2012

@lpsinger lpsinger added unit tests for Mollweide transforms
The new test functions test_mollweide_forward_inverse_closure and test_mollweide_inverse_forward_closure test that the forward->inverse and inverse->forward compositions are approximate identities.
40a9d48
@lpsinger lpsinger use ax.transProjection instead of ax.transData in Mollweide axes unit…
… test

The goal was to exercise the MollweideAxes.MollweideTransform and MollweideAxes.InvertedMollweideTransform classes. The ax.transData property does not make use of either of these classes; the ax.transProjection property does.
2ba7aef
@lpsinger lpsinger reduce precision to the level at which the test passes 6903325
Contributor

lpsinger commented Dec 30, 2012

I added the unit tests. The previous three commits (40a9d48, 2ba7aef, and 6903325) could be squashed together.

Owner

mdboom commented Jan 4, 2013

👍

@dmcdougall dmcdougall added a commit that referenced this pull request Jan 4, 2013

@dmcdougall dmcdougall Merge pull request #1624 from lpsinger/mollweide_inverse_transform
implemented inverse transform for Mollweide axes
3f76b21

@dmcdougall dmcdougall merged commit 3f76b21 into matplotlib:master Jan 4, 2013

1 check failed

default The Travis build failed
Details

@lpsinger lpsinger deleted the lpsinger:mollweide_inverse_transform branch Jan 4, 2013

Contributor

lpsinger commented Apr 16, 2013

Could this be merged into the next release?

Member

pelson commented Apr 16, 2013

Could this be merged into the next release?

It is already merged and on master, so yes, this will be in v1.3 (~June time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment