Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

add scatterpoints to rcParam #1634

Merged
merged 4 commits into from

3 participants

Thomas A Caswell Damon McDougall Varoquaux
Thomas A Caswell
Owner

Addresses Issue #1633

Includes units test that errors out with out the rest of this pull.

Varoquaux NelleV commented on the diff
lib/matplotlib/tests/test_legend.py
@@ -46,3 +46,22 @@ def test_fancy():
plt.errorbar(range(10), range(10), xerr=0.5, yerr=0.5, label='XX')
plt.legend(loc="center left", bbox_to_anchor=[1.0, 0.5],
ncol=2, shadow=True, title="My legend", numpoints=1)
+
+
Varoquaux Collaborator
NelleV added a note

PEP8 nitpick: there should be only 2 lines instead of 3 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Thomas A Caswell PEP8 fix b475c86
Damon McDougall
Collaborator

I think this is fine to merge. I will leave this open for a day just in case any of the other developers have further feedback they wish to give.

Varoquaux
Collaborator

:+1: LGTM

Damon McDougall
Collaborator

Travis failures are duds. Merging.

Damon McDougall dmcdougall merged commit 02582f8 into from
Thomas A Caswell tacaswell deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 4, 2013
  1. added unit test for rcParam['legend.scatterpoints']

    Thomas A Caswell authored
  2. added rcParam['legend.scatterpoints']

    Thomas A Caswell authored
  3. tweaked comments to no longer be a TODO

    Thomas A Caswell authored
Commits on Jan 14, 2013
  1. PEP8 fix

    Thomas A Caswell authored
Something went wrong with that request. Please try again.