Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add scatterpoints to rcParam #1634

Merged
merged 4 commits into from Jan 15, 2013

Conversation

Projects
None yet
3 participants
Owner

tacaswell commented Jan 4, 2013

Addresses Issue #1633

Includes units test that errors out with out the rest of this pull.

@NelleV NelleV commented on the diff Jan 14, 2013

lib/matplotlib/tests/test_legend.py
@@ -46,3 +46,22 @@ def test_fancy():
plt.errorbar(range(10), range(10), xerr=0.5, yerr=0.5, label='XX')
plt.legend(loc="center left", bbox_to_anchor=[1.0, 0.5],
ncol=2, shadow=True, title="My legend", numpoints=1)
+
+
@NelleV

NelleV Jan 14, 2013

Contributor

PEP8 nitpick: there should be only 2 lines instead of 3 here

Thomas A Caswell PEP8 fix b475c86
Member

dmcdougall commented Jan 14, 2013

I think this is fine to merge. I will leave this open for a day just in case any of the other developers have further feedback they wish to give.

Contributor

NelleV commented Jan 15, 2013

👍 LGTM

Member

dmcdougall commented Jan 15, 2013

Travis failures are duds. Merging.

@dmcdougall dmcdougall added a commit that referenced this pull request Jan 15, 2013

@dmcdougall dmcdougall Merge pull request #1634 from tacaswell/scatterpoint_rcParam
add scatterpoints to  rcParam
02582f8

@dmcdougall dmcdougall merged commit 02582f8 into matplotlib:master Jan 15, 2013

1 check failed

default The Travis build failed
Details

@tacaswell tacaswell deleted the tacaswell:scatterpoint_rcParam branch Jan 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment