Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Clean up code in cbook #1643

Merged
merged 2 commits into from Feb 18, 2013

Conversation

Projects
None yet
2 participants
Contributor

NelleV commented Jan 8, 2013

In this PR, I removed deprecated methods from 0.98.x - I moved some code to the tests, and I properly deprecated some methods (with a deprecation warning, and the release of removal).

This is a first PR before deprecating the module from the public interface.

@efiring efiring and 1 other commented on an outdated diff Feb 17, 2013

lib/matplotlib/cbook.py
@@ -831,6 +831,7 @@ def append(self, x):
if len(self.data) == self.max:
self.cur = 0
# Permanently change self's class from non-full to full
+ # FIXME __Full is not defined
@efiring

efiring Feb 17, 2013

Owner

__Full is defined just a few lines above

@NelleV

NelleV Feb 18, 2013

Contributor

I've deleted this line.

@efiring efiring commented on the diff Feb 17, 2013

lib/matplotlib/cbook.py
@@ -1608,8 +1609,9 @@ def delete_masked_points(*args):
return margs
+# FIXME I don't think this is used anywhere
@efiring

efiring Feb 17, 2013

Owner

True, not used in mpl. That's also the case with several other things in cbook.

@NelleV

NelleV Feb 18, 2013

Contributor

I'll deprecate the unused method in another PR.

Owner

efiring commented Feb 17, 2013

Apart from the two lines on which I left comments, I would merge this.

@efiring efiring added a commit that referenced this pull request Feb 18, 2013

@efiring efiring Merge pull request #1643 from NelleV/cleanup_cbook
Clean up code in cbook
0bf445a

@efiring efiring merged commit 0bf445a into matplotlib:master Feb 18, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment