Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added explicit 'zorder' kwarg to `Colection` and `LineCollection`. #1654

Merged
merged 2 commits into from Jan 14, 2013

Conversation

Projects
None yet
3 participants
Owner

tacaswell commented Jan 12, 2013

Vaguely related to issue #1622. Changed the location of the default zorder of Collection and LineCollection from a class level-member, to explicitly being a keyword argument.

I think this makes it clearer, but isn't strictly necessary, because if zorder is included as a kwarg, it will get set by the self.update anyway.

added explicit 'zorder' kwarg to `Colection` and `LineCollection`.
removed class level zorder assignment.

It is not strictly necessary for LineCollection to take zorder as a
kwarg, but added to keep the default zorder the same

@pelson pelson commented on an outdated diff Jan 14, 2013

lib/matplotlib/collections.py
@@ -959,6 +964,9 @@ def __init__(self, segments, # Can be None.
*pickradius* is the tolerance for mouse clicks picking a line.
The default is 5 pt.
+ *zorder*
+ 2 the zorder of the LineCollection
@pelson

pelson Jan 14, 2013

Member

This line should probably be more along the lines of:

Member

pelson commented Jan 14, 2013

Good stuff @tacaswell - I'm amazed we have come so far without zorder for Collections!

Member

dmcdougall commented Jan 14, 2013

Thanks @tacaswell, merging.

Member

dmcdougall commented Jan 14, 2013

(The Travis failures are duds)

dmcdougall added a commit that referenced this pull request Jan 14, 2013

Merge pull request #1654 from tacaswell/collection_zorder_kwarg
added explicit 'zorder' kwarg to `Colection` and `LineCollection`.

@dmcdougall dmcdougall merged commit 06d7f9c into matplotlib:master Jan 14, 2013

1 check failed

default The Travis build failed
Details

@tacaswell tacaswell deleted the tacaswell:collection_zorder_kwarg branch Jan 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment