Lower Text's FontProperties priority when updating

[omarchehab98]

Co-authored-by: Robert Augustynowicz robert.augustynowicz@mail.utoronto.ca
Closes: #16389

PR Summary

When fontproperties is being used, it's default values are overwriting explicit font attributes such as size.

plt.xlabel("value", fontproperties='SimHei',size=20) # this will work
plt.ylabel("counts",size=20, fontproperties='SimHei')  # this doesn't

Before

After

PR Checklist

• Has Pytest style unit tests
• Code is Flake 8 compliant
• New features are documented, with examples if plot related
• Documentation is sphinx and numpydoc compliant
• Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
• Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

[anntzer]

This should not use an image comparison test (per https://matplotlib.org/devdocs/devel/testing.html#writing-an-image-comparison-test), but either use check_figures_equal or much more simply just check the resulting text object's properties.

Anyone can dismiss when handled.

[omarchehab98]

@anntzer thank you for your feedback, I agree with the change you requested and have pushed a simpler unit test that asserts on the Text's size.

handled

[omarchehab98]

@timhoffm thank you for the good suggestion. I applied it. I think we're good to go, will it merge automatically?

[QuLogic]

Thanks @omarchehab98 !