Fixed the expected output from test_arrow_patches.test_fancyarrow. #1682

Merged
merged 1 commit into from Jan 19, 2013

Conversation

Projects
None yet
3 participants
Contributor

mgiuca-google commented Jan 18, 2013

Regenerated from test output.

This fixes Issue #1681.

Member

dmcdougall commented Jan 18, 2013

G'day!

Cheers for the pull request. @mdboom should have visibility of this before merging.

That bbox_inches test is on and off for me locally. Sometimes I get the failure and sometimes I don't and I can't seem to find a way to consistently reproduce it.

Contributor

mgiuca-google commented Jan 18, 2013

Urrgh, bbox_inches_test. Yeah, I've had it fail when I was testing my other branch (fixing the image comparison). From what I've seen, it's just subtle repositioning of the text, but it's hard to tell on Travis. I've addressed it in my other branch by bumping up the tolerance for that case.

I don't think it should block merging this PR, since clearly I can't have made it any worse by changing the expected output of another test.

Member

dmcdougall commented Jan 18, 2013

Yeah I agree. As you're already aware, image testing is rather complicated as it is. I appreciate the work you've put in to all of it. It takes a strong will and a pinch of insanity to tackle such a gargantuan task and you've done a great job. Thanks.

Contributor

mgiuca-google commented Jan 18, 2013

Yeah. I didn't realise how hard it would be when I started. :)

Member

dmcdougall commented Jan 19, 2013

Actually, on looking at the diff, this should very clearly be merged! The test image should actually contain fancy arrows. D'oh.

dmcdougall added a commit that referenced this pull request Jan 19, 2013

Merge pull request #1682 from mgiuca-google/fix-expected-test_arrow_p…
…atches

Fixed the expected output from test_arrow_patches.test_fancyarrow.

@dmcdougall dmcdougall merged commit 034b12b into matplotlib:master Jan 19, 2013

1 check failed

default The Travis build failed
Details
Owner

mdboom commented Jan 23, 2013

Hmm... the real question is why the fancy arrow test appeared as it did (empty) on my machine when I made the new baseline images. I guess if it happens again, the test will fail, and I'll know...

@mgiuca-google mgiuca-google deleted the mgiuca-google:fix-expected-test_arrow_patches branch Jan 24, 2013

Contributor

mgiuca-google commented Jan 24, 2013

FYI: It happened again when you generated the anti-aliased ones...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment