Fix hist for log=True and histtype='step' #1684

Merged
merged 6 commits into from Jan 27, 2013

Conversation

Projects
None yet
3 participants
Member

dmcdougall commented Jan 19, 2013

Rebased version of #1029 to target v1.2.x. This aims to fix #196 but is currently incomplete.

Member

dmcdougall commented Jan 19, 2013

Over in #1029 there was discussion of using the log's actual base rather than the magical number 0.1. This would be the correct solution aside from the fact that the axis scale is set to base ten inside hist (it's the default). If the user then changes the [xy]scale outside of hist, how do we change the plot to reflect the change of base without calling hist again?

Member

WeatherGod commented Jan 20, 2013

I wouldn't worry too much about a situation where the log base changes
after the call to hist. A lot of stuff breaks if you do any sort of
rescaling after the call to hist, and if it isn't already, it should be
well documented to establish your scales prior to any plotting.

Member

dmcdougall commented Jan 20, 2013

@WeatherGod Alright, thanks for that information.

Are there any other concerns that need to be addressed before this is merged? All tests pass locally on python 2.7.

@dmcdougall dmcdougall added a commit that referenced this pull request Jan 27, 2013

@dmcdougall dmcdougall Merge pull request #1684 from dmcdougall/fix_loghist
Fix hist for log=True and histtype='step'
2dc2825

@dmcdougall dmcdougall merged commit 2dc2825 into matplotlib:v1.2.x Jan 27, 2013

1 check passed

default The Travis build passed
Details

dmcdougall deleted the dmcdougall:fix_loghist branch Jan 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment