Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parameter initialization in Axes.specgram() #16947

Merged
merged 5 commits into from Apr 2, 2020

Conversation

Stefan-Mitic
Copy link
Contributor

@Stefan-Mitic Stefan-Mitic commented Mar 28, 2020

PR Summary

Added check to set Fs in _axes.specgram() to be Fs = freq[-1] * 2.
Added a test to test_axes.py to check if Fs is None that it won't throw an error.

Closes #9100

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo fixing the style issue.

@tacaswell
Copy link
Member

Thanks @Stefan-Mitic ! Other than the issue with the style, this looks good to me!

@tacaswell tacaswell added this to the v3.3.0 milestone Mar 30, 2020
@timhoffm timhoffm changed the title solution: docstring of parameter Fs of matplotlib.pyplot.specgram() inconsistent with default value #9100 Fix missing parameter initialization in Axes.specgram() Mar 31, 2020
@timhoffm timhoffm merged commit 97d9cd1 into matplotlib:master Apr 2, 2020
@timhoffm
Copy link
Member

timhoffm commented Apr 2, 2020

Thanks, and congratulations on your first contribution to Matplotlib. We hope to see you back some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter Fs initialization missing in Axes.specgram()
3 participants