Alpha kwarg fix #1695

Merged
merged 3 commits into from Jan 23, 2013

Conversation

Projects
None yet
5 participants
Owner

tacaswell commented Jan 23, 2013

Found another bug in #1505. My change ignored the alpha kwarg, this patch fixes it.

It also updates the way line color is handled (so alpha can be specified via kwarg or via a 4-tuple color), and updates the test to catch (I think) all of the permutations of marker, line, 4-tuple and

tacaswell added some commits Jan 23, 2013

@tacaswell tacaswell Fixed code added in 0c20b5c
(PR #1505).

Tests added is #1663 pass with this patch.
17fa943
@tacaswell tacaswell updated the way the line color + alpha is handled to match how it is
done for markers.  If a 4-tuple is passed in, the alpha from that will
be used, with the kwarg alpha over-ridding it.
edc48f0
@tacaswell tacaswell Updated the alpha/translucent test to also test lines and a mix of
setting alpha via color and via kwarg
842a164
Owner

tacaswell commented Jan 23, 2013

I mean this makes the tests added in #1675 pass.

Member

dmcdougall commented Jan 23, 2013

+1

Owner

mdboom commented Jan 23, 2013

+1

@dmcdougall dmcdougall added a commit that referenced this pull request Jan 23, 2013

@dmcdougall dmcdougall Merge pull request #1695 from tacaswell/alpha_kwarg_fix
Alpha kwarg fix
6cf6cbb

@dmcdougall dmcdougall merged commit 6cf6cbb into matplotlib:master Jan 23, 2013

1 check failed

default The Travis build failed
Details

tacaswell deleted the tacaswell:alpha_kwarg_fix branch Jan 23, 2013

Contributor

jakevdp commented on edc48f0 Jan 23, 2014

It looks like this commit broke something. The following code snippet worked in 1.2, but fails in 1.3, and I think it's due to this commit.

>>> from matplotlib import pyplot as plt
>>> plt.plot(range(10), color='none')
>>> plt.show()
Contributor

jakevdp replied Jan 23, 2014

Note that this came up here

Yeah, this is the broken line. It assumes that the ln_color_rgba will be index-able, but _get_rgb_face() can return a None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment