Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Contour does not pass a list of linestyles to LineCollection #1704

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

mdboom commented Jan 25, 2013

This is a possible fix for #1701. The LineCollection constructor's linestyle/linestyles kwarg expects a list of styles, but contour was passing it a single value.

Owner

mdboom commented Jan 25, 2013

@efiring may want to look at this.

Owner

mdboom commented Jan 25, 2013

Also: this will need a unit test before merging.

Owner

efiring commented Jan 26, 2013

It looks like that helps; but the whole business of setting dash patterns (a tuple within a tuple), together with the question of when one needs a list versus when one can get by with a single value, remains a confusing mess. And if one makes an error, it can trigger an incomprehensible PYCXX error message.
It looks like LineCollection.set_linestyle() works with a single value (as implied by the name) for strings, but not for those ugly dash specifications. In retrospect, we probably should have chosen a string syntax for the dash specification, so that linestyle(s) would always be a string or a sequence of strings. That would also allow a simpler specification for the usual case in which one doesn't need the offset part of the specification.

Member

dmcdougall commented Jan 31, 2013

Superceded by #1718.

@dmcdougall dmcdougall closed this Jan 31, 2013

@mdboom mdboom deleted the mdboom:dash_setting branch Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment