Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix set dashes for line collections #1718

Merged
merged 3 commits into from Jan 31, 2013

Conversation

Projects
None yet
2 participants
Member

dmcdougall commented Jan 29, 2013

Rebased version of #1704 targetting v1.2.x and with a unit test. It fixes #1701.

mdboom and others added some commits Jan 25, 2013

@mdboom @dmcdougall mdboom + dmcdougall Possible fix for #1701: Contour does not pass a list of linestyles to…
… LineCollection

Conflicts:
	lib/matplotlib/contour.py
20fe9f9
@dmcdougall dmcdougall Add test for setting dashes for line collections
Conflicts:
	lib/matplotlib/tests/test_lines.py
6408704
Member

dmcdougall commented Jan 29, 2013

@mdboom Is this unit test alright?

Owner

mdboom commented Jan 29, 2013

Sure -- I wonder if we also couldn't do a image test (or extend one of the existing contour tests) to make sure the dashes are in fact in the result.

Thanks for doing this -- I think we're still waiting to see if @efiring has any better way to fix the underlying bug(s)... I think this fix is probably fine for now (and is certainly minimal).

Member

dmcdougall commented Jan 29, 2013

Done.

Owner

mdboom commented Jan 30, 2013

Looks good.

Member

dmcdougall commented Jan 31, 2013

Alright, I think the best course of action is to merge this so it makes the release and if @efiring comes up with a cleaner approach, there's nothing to stop us pursuing it after the 1.2.1 release.

Any objections?

Owner

mdboom commented Jan 31, 2013

Seems right to me.

@dmcdougall dmcdougall added a commit that referenced this pull request Jan 31, 2013

@dmcdougall dmcdougall Merge pull request #1718 from dmcdougall/fix_set_dashes
Fix set dashes for line collections
b3f676c

@dmcdougall dmcdougall merged commit b3f676c into matplotlib:v1.2.x Jan 31, 2013

1 check passed

default The Travis build passed
Details

@dmcdougall dmcdougall deleted the dmcdougall:fix_set_dashes branch Jan 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment