Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolbar separators in wx+toolmanager. #17363

Merged
merged 1 commit into from May 17, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 8, 2020

The previous implementation was buggy likely because GetToolPos(tool.Id)
doesn't really work for separators, as they all share the same Id.

before:
old
after:
new

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added MEP: MEP22 tool manager GUI: wx labels May 8, 2020
@anntzer anntzer added this to the v3.3.0 milestone May 8, 2020
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing. Also seems to fix the Help tool.

The previous implementation was buggy likely because GetToolPos(tool.Id)
doesn't really work for separators, as they all share the same Id.
@anntzer
Copy link
Contributor Author

anntzer commented May 16, 2020

rebase

@timhoffm timhoffm merged commit 2240f34 into matplotlib:master May 17, 2020
@anntzer anntzer deleted the wxtb branch May 17, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants