Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make cbook safe to import while removing duplicate is_string_like; #1762

Merged
merged 2 commits into from Feb 19, 2013

Conversation

Projects
None yet
3 participants
Owner

efiring commented Feb 18, 2013

closes #1019, replaces #1662.

@pelson pelson and 1 other commented on an outdated diff Feb 19, 2013

lib/matplotlib/cbook.py
@@ -1,6 +1,14 @@
"""
A collection of utility functions and classes. Many (but not all)
-from the Python Cookbook -- hence the name cbook
+from the Python Cookbook -- hence the name cbook.
+
+This module is in transition, with the intention of migrating
@pelson

pelson Feb 19, 2013

Member

This paragraph is the only potential bone of contention for me. Has there been general agreement on transitioning cbook? FWIW I've read #1647 and the relevant mailing list discussion and still haven't found a definitive strategy - personally, I think anything of that scale should be covered by a MEP with a full transition plan.

On the basis of my comments, I wonder if we are better off not pre-empting that work here, and simply removing this paragraph?

@NelleV

NelleV Feb 19, 2013

Contributor

Moving the methods to a newly named module is debattable, but I think deprecating unused methods should still be done. I'm a a bit swamped with work right now, but I'll submit a new PR soon.

Member

pelson commented Feb 19, 2013

Other than my comment, 👍

@efiring efiring Update lib/matplotlib/cbook.py
Simplify module docstring, removing mention of possible future changes.
fb56db1

@efiring efiring added a commit that referenced this pull request Feb 19, 2013

@efiring efiring Merge pull request #1762 from efiring/cbook_safe_import
Make cbook safe to import while removing duplicate is_string_like;
433da1a

@efiring efiring merged commit 433da1a into matplotlib:master Feb 19, 2013

@efiring efiring deleted the efiring:cbook_safe_import branch Feb 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment