Simplify projection-of-point-on-polyline in contour.py. #17803
Merged
+37
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Jun 30, 2020
QuLogic
reviewed
Jul 18, 2020
| @@ -1333,7 +1305,7 @@ def find_nearest_contour(self, x, y, indices=None, pixel=True): | |||
| xmin, ymin : float | |||
| The point in the contour plot that is closest to ``(x, y)``. | |||
| d : float | |||
| The distance from ``(xmin, ymin)`` to ``(x, y)``. | |||
| The squared distance from ``(xmin, ymin)`` to ``(x, y)``. | |||
There was a problem hiding this comment.
This seems to be public, so I'm not sure we should change this.
There was a problem hiding this comment.
I'm just describing the actual behavior, not changing it.
anntzer
force-pushed
the
contproj
branch
2 times, most recently
from
3897689
to
7eea44c
Compare
timhoffm
reviewed
Jul 18, 2020
timhoffm
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist