Fix the clippath renderering so that it uses no-clip unsigned chars #1846

Merged
merged 2 commits into from Mar 25, 2013

Conversation

Projects
None yet
3 participants
Owner

mdboom commented Mar 22, 2013

This was discovered during the discussion in the e-mail thread "removing paths inside polygon".

When paths are affected by a clip path, the scanline type being used for rendering was wrong. It was grey8, but should be no_clip_grey8. This resulted in horizontal lines looking thicker than they should.

This also fixes a related performance bug where the buffer for the alpha mask was over-allocated by a factor of 4.

Owner

mdboom commented Mar 22, 2013

Note to self: before merging this, it should have a test.

Member

pelson commented Mar 22, 2013

Wow, this is low level. Nice spot.

before merging this, it should have a test.

Agreed.

Whilst I agree it's a bug fix, I also wonder if we are better off sticking this in v1.3 to avoid any potential negative impacts this change could have?

Owner

mdboom commented Mar 25, 2013

I think I'm leaning toward putting this in 1.2.x -- while it may change the appearance of some plots, it should do what the user means and give lines that are the requested thickness. Since none of the tests failed or required tweaking, I'm even more on the side of calling this a simple bugfix. Any tie-breaking points of view? 😉

Member

dmcdougall commented Mar 25, 2013

1.2 sounds good to me.

Before you push the green button to release the magical GitHub ponies, is there still going to be a test?

Owner

mdboom commented Mar 25, 2013

Yes -- a test shall appear shortly.

Member

dmcdougall commented Mar 25, 2013

@mdboom Thanks :)

Owner

mdboom commented Mar 25, 2013

Travis failure is false.

@mdboom mdboom added a commit that referenced this pull request Mar 25, 2013

@mdboom mdboom Merge pull request #1846 from mdboom/agg-clip-rendering-fix
Fix the clippath renderering so that it uses no-clip unsigned chars
c789f0f

@mdboom mdboom merged commit c789f0f into matplotlib:v1.2.x Mar 25, 2013

1 check failed

default The Travis build could not complete due to an error
Details

mdboom deleted the mdboom:agg-clip-rendering-fix branch Aug 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment