Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cbook._check_in_list() to _api.check_in_list() #18494

Merged
merged 1 commit into from Sep 17, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 15, 2020

PR Summary

Start addresses the following section of #16181:

Move all the internal cbook functions to (a/multiple) private module(s).

from matplotlib import _api

@_api.deprecated("3.2")
def compare_versions(a, b):

reads better than the current

from matplotlib import cbook

@cbook._deprecated("3.2")
def compare_versions(a, b):

and it does not pollute the namespace with the public package name.

This PR does:

  • Move cbook._check_in_list() to _api.check_in_list()

@timhoffm timhoffm added this to the v3.4.0 milestone Sep 15, 2020
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor nit.

lib/matplotlib/lines.py Outdated Show resolved Hide resolved
@QuLogic
Copy link
Member

QuLogic commented Sep 16, 2020

Start addresses the following section of #18176:

That seems to be the wrong issue reference?

@timhoffm
Copy link
Member Author

Sorry, should have been #16181. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants