Cleanup stem docs and simplify implementation. #18937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the implementation side, we can use
vlines
/hlines
to generate thecorrect
LineCollection
.On the documentation side, it seems perfectly valid to only specify a
linestyle and no color in
linefmt
(e.g.stem([0, 1], [2, 3], linefmt="-.")
works just fine). On the otherhand markers are indeed silently dropped (possibly we could emit a
warning there, but that should be another PR). So reword accordingly;
and also slighly reword the doc for
markerfmt
.Noted while reviewing #18310.
@timhoffm You wrote in #10154 that just setting the linestyle (
-.
) is "beyond the intention of the method" but did I miss something?PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).