Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_helper_curvelinear cleanups. #19035

Merged
merged 1 commit into from Nov 28, 2020
Merged

grid_helper_curvelinear cleanups. #19035

merged 1 commit into from Nov 28, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 27, 2020

  • np.full already defaults to the dtype of the value passed in, no
    need to explicitly pass it.
  • set_extremes already normalizes None to +/-inf, no need to handle
    them again in get_tick_iterators. Also, set_extremes and
    update_lim already clearly assume that extremes are sorted, so
    unsorted extremes already break elsewhere, so no need to sort them in
    get_tick_iterators.
  • There's a public setter for extremes, no need to touch private
    attributes in test_axis_direction.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

- `np.full` already defaults to the dtype of the `value` passed in, no
  need to explicitly pass it.
- `set_extremes` already normalizes None to +/-inf, no need to handle
  them again in `get_tick_iterators`.  Also, `set_extremes` and
  `update_lim` already clearly assume that extremes are sorted, so
  unsorted extremes already break elsewhere, so no need to sort them in
  `get_tick_iterators`.
- There's a public setter for extremes, no need to touch private
  attributes in test_axis_direction.
@timhoffm timhoffm added this to the v3.4.0 milestone Nov 28, 2020
@timhoffm timhoffm merged commit 62cdc93 into matplotlib:master Nov 28, 2020
@anntzer anntzer deleted the ghc branch November 28, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants