Spectral plot unit tests #1906

Merged
merged 3 commits into from Apr 16, 2013

Projects

None yet

4 participants

@toddrjen
Contributor

Unit tests for the spectral plot types (specgram, psd, and csd) and corresponding mlab functions.

Owner
mdboom commented Apr 15, 2013

Very nice and much needed pull request.

I wonder, however, whether we need to test all three of png, pdf and svg for these. The pdf and svg files in particular are quite large. (Yes, I know our test suite already has some files of that size, but all the more reason to avoid expanding further... 😉). Maybe we should test PNG only (as those are the smallest files), unless there is some known bug that shows up only with the other formats. Note, we currently do this for the delaunay triangulation tests for the same reason.

Member

Yes. Also, there still appears to be some text on some of the output files.

Contributor

I've restricted it to only pngs and removed the text from the images

Contributor

Fixed for python 2.6

Member
pelson commented Apr 16, 2013

👍

Owner
mdboom commented Apr 16, 2013

Looks good -- and thanks for amending the commit so the PDFs and SVGs don't make it into the history.

Merging.

@mdboom mdboom merged commit f39cdb6 into matplotlib:master Apr 16, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment