Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore CLOSEPOLY vertices when computing dataLim from patches #19088

Merged
merged 6 commits into from Dec 24, 2020

Conversation

jsberg-bnl
Copy link

@jsberg-bnl jsberg-bnl commented Dec 9, 2020

PR Summary

CLOSEPOLY verticies are not actual points in a path, but _update_patch_limits uses them anyhow when computing dataLim. This patch removes the CLOSEPOLY vertices from the list of vertices used in the computation. Fixes #19078.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

lib/matplotlib/tests/test_axes.py Outdated Show resolved Hide resolved
lib/matplotlib/tests/test_axes.py Outdated Show resolved Hide resolved
@QuLogic QuLogic merged commit 3798e5f into matplotlib:master Dec 24, 2020
@QuLogic
Copy link
Member

QuLogic commented Dec 24, 2020

Thanks @jsberg-bnl ! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@QuLogic QuLogic added this to the v3.4.0 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_update_patch_limits should not use CLOSEPOLY verticies for updating
3 participants