Fixed failing bbox_inches='tight' case when a contour collection is empty #1929

Merged
merged 1 commit into from May 3, 2013

Projects

None yet

4 participants

Contributor
NelleV commented Apr 22, 2013

LGTM 👍 for merge

Owner
mdboom commented Apr 22, 2013

Maybe rebase for the 1.2.x branch, then looks good to me.

Member
pelson commented Apr 22, 2013

Maybe rebase for the 1.2.x branch, then looks good to me.

You're right that the bug has existed for a good while, but it is only manifest with a recent change to master, so nobody is going to see this unless they are doing some pretty low-level interface stuff. Long and short: I'm not that keen to rebase as I don't think it will make much difference, and I haven't verified that the change makes sense before the change that made this a problem.

Obviously, if you feel strongly about it, I'd be happy enough to rebase against v1.2.x to get this merged.

Cheers,

Contributor
pmarshwx commented May 3, 2013

My vote is to merge this to master and then not worry about back-porting if you are unsure about this breaking something in v1.2.x. As the one who posted this to the IPython listserv, getting this fix into master sooner rather than later will greatly help my local codebase.

Just my $0.02

@mdboom mdboom merged commit 668690d into matplotlib:master May 3, 2013

1 check passed

default The Travis build passed
Details
Member
pelson commented May 3, 2013

Thanks @mdboom

Owner
mdboom commented May 3, 2013

FWIW: I did cherry-pick this to 1.2.x as well.

Member
pelson commented May 3, 2013

FWIW: I did cherry-pick this to 1.2.x as well.

😄 thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment